build(mac): add branded dmg layout#2013
Conversation
📝 WalkthroughWalkthroughThe PR configures macOS DMG presentation and packaging detection, updates ACP agent releases, and expands provider model metadata with new models, capabilities, limits, endpoints, dates, and pricing. ChangesDMG packaging
ACP agent registry
Provider model catalog
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
resources/model-db/providers.json (1)
123760-123763: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winDisambiguate the two
Inklingentries' display names.The base
thinkingmachines/Inklingand thethinkingmachines/Inkling:peft:262144variant both carryname/display_name="Inkling", so they render as two indistinguishable options in the model picker. Consider differentiating the PEFT/262k-context variant.♻️ Suggested change
"id": "thinkingmachines/Inkling:peft:262144", - "name": "Inkling", - "display_name": "Inkling", + "name": "Inkling (PEFT 262K)", + "display_name": "Inkling (PEFT 262K)",🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@resources/model-db/providers.json` around lines 123760 - 123763, Update the display_name for the thinkingmachines/Inkling:peft:262144 model entry to distinguish it from the base thinkingmachines/Inkling option, while preserving its id and name fields.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@resources/model-db/providers.json`:
- Around line 204665-204668: Update the limit.output value for the
veo-3.1-generate-preview provider entry from 1 to 8192, matching the sibling Veo
3.1 preview variants and preserving the existing context limit.
---
Nitpick comments:
In `@resources/model-db/providers.json`:
- Around line 123760-123763: Update the display_name for the
thinkingmachines/Inkling:peft:262144 model entry to distinguish it from the base
thinkingmachines/Inkling option, while preserving its id and name fields.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 28840977-f03b-49e2-984e-ba8e1e5d0078
⛔ Files ignored due to path filters (2)
build/dmg-background.pngis excluded by!**/*.pngbuild/dmg-background@2x.pngis excluded by!**/*.png
📒 Files selected for processing (7)
electron-builder.ymlresources/acp-registry/registry.jsonresources/model-db/providers.jsonscripts/ci/classify-package-impact.mjstest/main/scripts/dmgLayout.test.tstest/main/scripts/notarizeDmg.test.tstest/main/scripts/packageContract.test.ts
/Applicationslink positionsSummary by CodeRabbit
New Features
Bug Fixes